Wrong CMakeLists.txt for recognition model causes incorrect installation of ObjRecRANSAC module #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs at old locations which include the headers at the new locations and deprecation warnings.
…de the new ones. Only the new header files were installed in the previous commit
| include/pcl/${SUBSYS_NAME}/impl/ransac_based/simple_octree.hpp | ||
| include/pcl/${SUBSYS_NAME}/impl/ransac_based/voxel_structure.hpp | ||
| include/pcl/${SUBSYS_NAME}/impl/implicit_shape_model.hpp | ||
| #include/pcl/${SUBSYS_NAME}/impl/ransac_based/simple_octree.hpp |
There was a problem hiding this comment.
I would imagine users with old code would include the header files (.h) but not include the (.hpp) files directly so what would be the use of having these files?
There was a problem hiding this comment.
The .hpp are needed to compile the templated code, for example with a new point type. I would propose to keep all old files and remove them all together in the future.
jspricke
added a commit
that referenced
this pull request
Sep 30, 2013
Wrong CMakeLists.txt for recognition model causes incorrect installation of ObjRecRANSAC module
aPonza
pushed a commit
to aPonza/pcl
that referenced
this pull request
Apr 11, 2020
truhoang
pushed a commit
to truhoang/pcl
that referenced
this pull request
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recognition/CMakeLists.txt causes installation of ransac_based/ files to be installed under recognition/ directly instead of being installed in the subdirectory ransac_based/. This breaks the ObjRecRansac code files because they try to include headers in the ransac_based/ subfolder.