Fix 3d_rec_framework compilation error #2495
Conversation
| @@ -22,8 +22,7 @@ template<template<class > class Distance, typename PointInT, typename FeatureT> | |||
| typedef std::pair<std::string, int> mv_pair; | |||
| mv_pair pair_model_view = std::make_pair (model.id_, view_id); | |||
|
|
|||
| std::map<mv_pair, Eigen::Matrix4f, std::less<mv_pair>, Eigen::aligned_allocator<std::pair<mv_pair, Eigen::Matrix4f> > >::iterator it = | |||
| poses_cache_.find (pair_model_view); | |||
| auto it = poses_cache_.find (pair_model_view); | |||
There was a problem hiding this comment.
Unfortunately we can only adopt this once we move to C++14. Right now this is not supported.
There was a problem hiding this comment.
auto is supported since C++11, not C++14.
That's why I used it. Anyway, if you want me to revert this to its previous type declaration I'll do it right away.
There was a problem hiding this comment.
PCL is currently on C++03, not C++11. We're skipping C++11 entirely and going straight for C++14.
There was a problem hiding this comment.
PCL is currently on C++03, not C++11. We're skipping C++11 entirely and going straight for C++14.
Ok, now it's also clear to me why the topic about C++14. There's a skip of C++11 that I missed altogether 😄
Roger. Reverting the iterator right now.
| @@ -463,8 +463,7 @@ template<template<class > class Distance, typename PointInT, typename FeatureT> | |||
| typedef std::pair<std::string, int> mv_pair; | |||
| mv_pair pair_model_view = std::make_pair (model.id_, view_id); | |||
|
|
|||
| std::map<mv_pair, Eigen::Matrix4f, std::less<mv_pair>, Eigen::aligned_allocator<std::pair<mv_pair, Eigen::Matrix4f> > >::iterator it = | |||
| poses_cache_.find (pair_model_view); | |||
| auto it = poses_cache_.find (pair_model_view); | |||
Eigen::aligned_allocator was set unproperly. A const declaration was missing in template type. See http://eigen.tuxfamily.org/dox/group__TopicStlContainers.html.
claudiofantacci
force-pushed
the
fix/eigengenerator
branch
from
cb319fb to
af83b86
Compare
|
Ok, done 👍 |
|
Thanks. |
Eigen::aligned_allocatorwas set unproperly.A
constdeclaration was missing in template type.See here for fruther documentation bout the error.
I also changed explicit iterator type declaration with
auto, which is much more compact and less error prone (avoids redundant repetition of type names).