Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax precision requirements on TransformationEstimationLM test. #2497

Merged

Conversation

SergioRAgostinho
Copy link
Member

This test was failing on my 18.04 environment. The demanded precision seemed tight so I bumped it up to match the translation component.

$ build/test/registration/test_registration_api test/bun0.pcd test/bun4.pcd
[==========] Running 14 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 14 tests from PCL
[ RUN      ] PCL.CorrespondenceEstimation
[       OK ] PCL.CorrespondenceEstimation (1 ms)
[ RUN      ] PCL.CorrespondenceEstimationReciprocal
[       OK ] PCL.CorrespondenceEstimationReciprocal (0 ms)
[ RUN      ] PCL.CorrespondenceRejectorDistance
[       OK ] PCL.CorrespondenceRejectorDistance (1 ms)
[ RUN      ] PCL.CorrespondenceRejectorMedianDistance
[       OK ] PCL.CorrespondenceRejectorMedianDistance (0 ms)
[ RUN      ] PCL.CorrespondenceRejectorOneToOne
[       OK ] PCL.CorrespondenceRejectorOneToOne (1 ms)
[ RUN      ] PCL.CorrespondenceRejectorSampleConsensus
[       OK ] PCL.CorrespondenceRejectorSampleConsensus (2 ms)
[ RUN      ] PCL.CorrespondenceRejectorSurfaceNormal
[       OK ] PCL.CorrespondenceRejectorSurfaceNormal (2 ms)
[ RUN      ] PCL.CorrespondenceRejectorTrimmed
[       OK ] PCL.CorrespondenceRejectorTrimmed (0 ms)
[ RUN      ] PCL.CorrespondenceRejectorVarTrimmed
[       OK ] PCL.CorrespondenceRejectorVarTrimmed (1 ms)
[ RUN      ] PCL.TransformationEstimationSVD
[       OK ] PCL.TransformationEstimationSVD (0 ms)
[ RUN      ] PCL.TransformationEstimationDualQuaternion
[       OK ] PCL.TransformationEstimationDualQuaternion (0 ms)
[ RUN      ] PCL.TransformationEstimationPointToPlaneLLS
[       OK ] PCL.TransformationEstimationPointToPlaneLLS (0 ms)
[ RUN      ] PCL.TransformationEstimationLM
/home/sergio/Development/3rdparty/pcl/test/registration/test_registration_api.cpp:529: Failure
The difference between R_LM_1_float.x () and R_ref.x () is 0.00015111267566680908, which exceeds 1e-4f, where
R_LM_1_float.x () evaluates to 0.10496655851602554,
R_ref.x () evaluates to 0.10511767119169235, and
1e-4f evaluates to 9.9999997473787516e-05.
/home/sergio/Development/3rdparty/pcl/test/registration/test_registration_api.cpp:530: Failure
The difference between R_LM_1_float.y () and R_ref.y () is 0.0001913607120513916, which exceeds 1e-4f, where
R_LM_1_float.y () evaluates to -0.26260280609130859,
R_ref.y () evaluates to -0.26279416680335999, and
1e-4f evaluates to 9.9999997473787516e-05.
/home/sergio/Development/3rdparty/pcl/test/registration/test_registration_api.cpp:531: Failure
The difference between R_LM_1_float.z () and R_ref.z () is 0.00033326447010040283, which exceeds 1e-4f, where
R_LM_1_float.z () evaluates to 0.15800976753234863,
R_ref.z () evaluates to 0.15767650306224823, and
1e-4f evaluates to 9.9999997473787516e-05.
[  FAILED  ] PCL.TransformationEstimationLM (4 ms)
[ RUN      ] PCL.TransformationEstimationPointToPlane
[       OK ] PCL.TransformationEstimationPointToPlane (0 ms)
[----------] 14 tests from PCL (12 ms total)

[----------] Global test environment tear-down
[==========] 14 tests from 1 test case ran. (12 ms total)
[  PASSED  ] 13 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] PCL.TransformationEstimationLM

 1 FAILED TEST

@SergioRAgostinho
Copy link
Member Author

This one is good to go! Registration tests are now passing.

@taketwo taketwo merged commit ac27a0d into PointCloudLibrary:master Oct 2, 2018
@SergioRAgostinho SergioRAgostinho deleted the relax-registration-api branch October 2, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants