Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When configuring with WITH_DOCS, but Doxygen is not available, prevent generation. #2516

Merged
merged 1 commit into from
Oct 8, 2018
Merged

When configuring with WITH_DOCS, but Doxygen is not available, prevent generation. #2516

merged 1 commit into from
Oct 8, 2018

Conversation

fidergo-stephane-gourichon
Copy link
Contributor

…t generation.

SergioRAgostinho
SergioRAgostinho reviewed Oct 5, 2018
View reviewed changes
doc/doxygen/CMakeLists.txt Outdated
@@ -2,6 +2,8 @@ if(WITH_DOCS)
find_package(Doxygen)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about actually passing here REQUIRED to the find package command?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better. I modify the code.

@SergioRAgostinho SergioRAgostinho added module: cmake needs: author reply Specify why not closed/merged yet labels Oct 5, 2018
@fidergo-stephane-gourichon
Copy link
Contributor Author

Seems there is a failed check in travis.

gcc build works but
clang build fails with:

The job exceeded the maximum time limit for jobs, and has been terminated.

The gcc build appears to build much less than the clang build.

It's strange.
It builds upon #2502
which passes the integration test.

Making doxygen required in case of building docs can't possibly change dramatically the items built.

Any clue?

@SergioRAgostinho
Copy link
Member

It's a Travis CI problem. Disregard it.

@SergioRAgostinho
Copy link
Member

You seemed to have pushed a new commit after my comment, but nothing was modified.

@fidergo-stephane-gourichon
Copy link
Contributor Author

Thanks for reporting wrong commit pushed.

I just pushed the correct commit, rebased on latest PointCloudLibrary/pcl master.

Tested here:

  • default configuration, without doxygen, cmake succeeds
  • WITH_DOCS enable, without doxygen, cmake fails
  • WITH_DOCS enable, with doxygen, cmake succeeds

Seems all good for me.

@SergioRAgostinho SergioRAgostinho removed the needs: author reply Specify why not closed/merged yet label Oct 8, 2018
@SergioRAgostinho SergioRAgostinho changed the title When configuring with WITH_DOCS, but Doxygen is not available, preven… When configuring with WITH_DOCS, but Doxygen is not available, prevent generation. Oct 8, 2018
@SergioRAgostinho SergioRAgostinho merged commit f7dd2e8 into PointCloudLibrary:master Oct 8, 2018
@SergioRAgostinho
Copy link
Member

Thank you for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho left review comments

Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fidergo-stephane-gourichon @SergioRAgostinho