Remove sm_72 from CUDA 9.0 #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in cmake/pcl_find_cuda.cmake
taketwo
approved these changes
Oct 18, 2018
|
Thanks! Side note: you did not need to close the previous pull request and create a new one. You could just push more commits to the pull request branch and they would become part of the pull request automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because CUDA Toolkit 9.0 doesn't support sm_72... (also mentioned in #2566)
This PR has some fix in cmake/pcl_find_cuda.cmake. This makes CMake skip sm_72 code generation when CUDA 9.0(not 9.1 or 9.2)is in use. Please check it out.