Corrections to Windows unit tests. #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A past-the-end iterator was dereferenced.
When an exception was thrown during object construction, the destructor calls serializeMetadataToDisk that dereferences null objects. Simplification of the original commit 0995009 by @claudiofantacci .
The number of thread passed to OpenMP must be greater than 0. The default for OpenMP classes is 0. With this commit, by setting 0, the number of threads is set to the number of cores detected on the machine. Closes PointCloudLibrary#2568
The test compiles differntly if the configuration is Release or Debug. In Debug mode, threads are required to finish their task in 15 seconds instead of 1. Closes 2585
|
LGTM, thank you! |
|
100% tests passed! Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a PR incorporating selected commits by @claudiofantacci as explained here
#2399 (comment) .
After the merge I will "race" to finish the release. @PointCloudLibrary/maintainers if there's anyone out there with a little time please merge this if the tests run normally. Be aware that AppVeyor is randomly timing out so check that one with some care.
Closes #2585