Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMake policy CMP0054 setting. #2627

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

SergioRAgostinho
Copy link
Member

I compiled, ran tests and linked against a downstream target. It seems our code was already compliant and it didn't cause any issues.

At some point the PCLConfig was reporting "duplicate targets" again. After deleting and rebuilding I could no longer replicate this situation. I would still suggest other @PointCloudLibrary/maintainers to actually give it a try on their local platforms before merging.

@taketwo
Copy link
Member

taketwo commented Nov 20, 2018

I searched for occurrences of if(" in our CMake scripts and whatever I found does not seem to be using the old "double-expansion" behavior. I also built/installed PCL and tested with one dependent project, works fine.

@taketwo taketwo merged commit daa671e into PointCloudLibrary:master Nov 20, 2018
@SergioRAgostinho SergioRAgostinho deleted the policy-54 branch November 23, 2018 22:45
@SunBlack
Copy link
Contributor

SunBlack commented Dec 21, 2018

I don't know if this warning is new since this PR, but I'm getting always:

CMake Warning (dev) at /usr/lib/cmake/vtk-6.3/VTKTargets.cmake:28 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "" will no longer be dereferenced when the policy is
  set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  /usr/lib/cmake/vtk-6.3/VTKConfig.cmake:60 (include)
  CMakeLists.txt:368 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

Don't know why we don't see it on Azure build machines. I have a VM with Ubuntu 18.04 and all dependencies installed via apt-get:

sudo apt-get install build-essential clang ccache cmake-qt-gui freeglut3-dev libglew-dev qt5-default libvtk6-qt-dev libusb-1.0-0-dev libopenni-dev libopenni2-dev libboost-all-dev libeigen3-dev libflann-dev googletest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants