Remove CMake policy CMP0054 setting. #2627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I compiled, ran tests and linked against a downstream target. It seems our code was already compliant and it didn't cause any issues.
At some point the PCLConfig was reporting "duplicate targets" again. After deleting and rebuilding I could no longer replicate this situation. I would still suggest other @PointCloudLibrary/maintainers to actually give it a try on their local platforms before merging.