Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer standard [[deprecated]] attribute #2699

Merged

Conversation

taketwo
Copy link
Member

@taketwo taketwo commented Dec 9, 2018

The [[deprecated]] attribute is part of the standard; no workarounds for different compilers is needed anymore. Thus PCL_DEPRECATED macro is removed.

The [[deprecated]] attribute is part of the standard; no workarounds for
different compilers is needed anymore. Thus PCL_DEPRECATED macro is
removed.
@taketwo
Copy link
Member Author

taketwo commented Dec 9, 2018

By the way, this attribute was first introduced in c++14. As such, this can be a good candidate for cxx_std_14 proxy to solve #2697.

Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SergioRAgostinho SergioRAgostinho merged commit d191374 into PointCloudLibrary:master Dec 10, 2018
@taketwo taketwo deleted the deprecated-attribute branch December 10, 2018 12:53
@7680x4320
Copy link
Contributor

7680x4320 commented Feb 14, 2019

MSVC 2015 Update 3 can't build segmentation module after this change.
It seems a bug of MSVC 2015 Update 3.

@taketwo
Copy link
Member Author

taketwo commented Feb 14, 2019

If I interpret the answer you linked correctly, then the only problem is SupervoxelClustering constructor, which is declared but not defined in the header? We can simply move the definition to the header, especially considering the fact that it's exactly the same as the other constructor. That is, have the following:

[[deprecated("jadda jadda...")]]
SupervoxelClustering (float voxel_resolution, float seed_resolution, bool) : SupervoxelClustering (voxel_resolution, seed_resolution) { }

@7680x4320
Copy link
Contributor

Your solution works fine, thanks!

@taketwo
Copy link
Member Author

taketwo commented Feb 16, 2019

Great, please send a PR.

@taketwo taketwo changed the title Switch to standard [[deprecated]] attribute Prefer standard [[deprecated]] attribute Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants