Replace #ifndef include guards by #pragma once
#2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please double-check if the tutorial files that you modified are referenced in tutorial text. If so, code block includes should be adjusted. (See for example this commit: bed8e54.) |
|
Searched for |
taketwo
reviewed
Dec 12, 2018
SunBlack
force-pushed
the
pragma_once
branch
from
736ffba to
4fc42d3
Compare
taketwo
changed the title
#ifndef include guards by #pragma once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #429/#2617. Last time I searched for
#include PCL, now I searched just for#ifndef. I just skipped3rdpartydirectory (opennurbs/poisson4), because I'm not sure how you handle 3rdParty libraries.There could be a compile issue, because some macros were multiple times used:
pcl/doc/tutorials/content/sources/iros2011/include/object_recognition.h
Lines 1 to 2 in 5cef903
pcl/doc/tutorials/content/sources/iros2011/include/solution/object_recognition.h
Lines 1 to 2 in 5cef903
pcl/doc/tutorials/content/sources/iros2011/include/surface.h
Lines 1 to 2 in 5cef903
pcl/doc/tutorials/content/sources/iros2011/include/solution/surface.h
Lines 1 to 2 in 5cef903
I didn't checked if we can remove solution directory or not, because it seems to be just a copy of parent directory.