Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary VTK_INCLUDE_DIRECTORIES #2713

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Remove unnecessary VTK_INCLUDE_DIRECTORIES #2713

merged 1 commit into from
Dec 14, 2018

Conversation

SunBlack
Copy link
Contributor

Since VTK 6 there are imported targets (as far as I read), so it explicit includes are not necessary anymore.

@SunBlack SunBlack mentioned this pull request Dec 13, 2018
Merged
@taketwo
Copy link
Member

taketwo commented Dec 14, 2018

Sidenote: @jasjuang you are always welcome to submit an "official" review, not just an emoji reaction 😉

@taketwo taketwo merged commit b039b62 into PointCloudLibrary:master Dec 14, 2018
@SunBlack SunBlack deleted the VTK_INCLUDE_DIRECTORIES branch December 14, 2018 14:21
@SunBlack
Copy link
Contributor Author

Addition: VTK 6 does not define imported targets (I found an discussion about this from 2017 here). But reason why this PR worked: ${VTK_INCLUDE_DIRECTORIES} is wrong. Correct is ${VTK_INCLUDE_DIRS} (see here).

@taketwo
Copy link
Member

taketwo commented Dec 14, 2018

Thanks for the reference 👍

@taketwo taketwo changed the title Remove unnecessary VTK_INCLUDE_DIRECTORIES. Remove unnecessary VTK_INCLUDE_DIRECTORIES Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunBlack @taketwo