Fix source file name path stripping in Doxygen #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the STRIP_FROM_PATH option is not set, as a result the full path of source files is "leaked" into the generated HTML. For example, this documentation page: http://docs.pointclouds.org/1.9.1/voxel__grid__occlusion__estimation_8h_source.html Has the following title: <title>Point Cloud Library (PCL): /__w/1/s/filters/include/pcl/filters/voxel_grid_occlusion_estimation.h Source File</title> This is an absolute path on Azure Pipelines worker. We already have path stripping set up properly in STRIP_FROM_INC_PATH, so this commit just copies the same paths over. Additionally indentation is fixed in the generated Doxyfile by using spaces instead of tabs.
SergioRAgostinho
force-pushed
the
fix-doxygen-path-stripping
branch
from
391ecb7 to
35b339e
Compare
SergioRAgostinho
approved these changes
Jan 7, 2019
|
Just to report that the problem still persists. |
|
Sorry the link I posted is misleading. It points to 1.9.1 release page, and it's not gonna change of course. The trunk documentation is fixed, as may be observed here: http://docs.pointclouds.org/trunk/voxel__grid__occlusion__estimation_8h_source.html. |
|
I actually was looking into the trunk version. Maybe, the page was cached. Glad all is well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
STRIP_FROM_PATHoption is not set, as a result the full path of source files is "leaked" into the generated HTML. For example, this documentation page has the following title:This is an absolute path on Azure Pipelines worker.
We already have path stripping set up properly in
STRIP_FROM_INC_PATH, so this commit just copies the same paths over.Additionally indentation is fixed in the generated Doxyfile by using spaces instead of tabs.