Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug prone loop variables that are too small #2829

Merged
merged 3 commits into from
Feb 8, 2019
Merged

Fix bug prone loop variables that are too small #2829

merged 3 commits into from
Feb 8, 2019

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Feb 6, 2019

Fix issues reported by run-clang-tidy -header-filter='.*' -checks='-*,bugprone-too-small-loop-variable'

@SunBlack SunBlack mentioned this pull request Feb 6, 2019
Open
SergioRAgostinho
SergioRAgostinho reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments in situ.

I also wanted to check if this PR added some sign-compare warnings but gave up once I realized that our CI Ubuntu and Mac are flooding with warnings. 😅

segmentation/include/pcl/segmentation/impl/organized_connected_component_segmentation.hpp Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d_pdm.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_2d_pdm.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_pdm.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_pdm.cpp Outdated Show resolved Hide resolved
surface/src/on_nurbs/fitting_curve_pdm.cpp Outdated Show resolved Hide resolved
@SergioRAgostinho
Copy link
Member

I forgot to mention. Don't squash commits, we'll take care of that at the end.

SergioRAgostinho
SergioRAgostinho approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This PR increased my size_t happiness.

segmentation/include/pcl/segmentation/impl/organized_connected_component_segmentation.hpp Show resolved Hide resolved
@SergioRAgostinho SergioRAgostinho merged commit 1cb184d into PointCloudLibrary:master Feb 8, 2019
@SunBlack SunBlack deleted the bugprone-too-small-loop-variable branch February 8, 2019 09:38
@taketwo taketwo changed the title Fix too small loop variables Fix bug prone loop variables that are too small Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @SergioRAgostinho @taketwo