Transform classic loops to range-based for loops in module tracking #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunBlack
force-pushed
the
range_based_loops_tracking
branch
from
44946fc to
c5ddeeb
Compare
taketwo
approved these changes
Feb 9, 2019
There was a problem hiding this comment.
These changes are a bit more involved than just auto-ization of a loop 😄
Introduced optimizations LGTM, however technically we are changing the API for deriving classes. Somehow, I think it's rather unlikely there exist deriving classes in the wild, so would be OK to just merge this change without deprecation cycle.
taketwo
added
changelog: API break
|
I know, but I don't even have an idea why this methods are virtual, because they are just simple helper methods. |
Changes are based on the result of run-clang-tidy -header-filter='.*' -checks='-*,modernize-loop-convert' -fix
SunBlack
force-pushed
the
range_based_loops_tracking
branch
from
c5ddeeb to
08110c0
Compare
|
Same here: Just edited typo in commit message via force push (just saw that I copy & pasted a typo across my last PRs) |
SunBlack
changed the title
SergioRAgostinho
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are based on the result of run-clang-tidy -header-filter='.' -checks='-,modernize-loop-convert' -fix