Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform classic loops to range-based for loops in module gpu #2844

Merged

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented Feb 9, 2019

Changes are based on the result of run-clang-tidy -header-filter='.' -checks='-,modernize-loop-convert' -fix

Changes are based on the result of run-clang-tidy -header-filter='.*' -checks='-*,modernize-loop-convert' -fix
gpu/people/src/organized_plane_detector.cpp Outdated Show resolved Hide resolved
gpu/people/src/people_detector.cpp Outdated Show resolved Hide resolved
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments with respect to the chosen names.

gpu/people/include/pcl/gpu/people/label_tree.h Outdated Show resolved Hide resolved
gpu/people/include/pcl/gpu/people/label_tree.h Outdated Show resolved Hide resolved
gpu/people/include/pcl/gpu/people/label_tree.h Outdated Show resolved Hide resolved
gpu/people/src/people_detector.cpp Outdated Show resolved Hide resolved
@SergioRAgostinho SergioRAgostinho merged commit 3f2f9fc into PointCloudLibrary:master Mar 8, 2019
@SunBlack SunBlack deleted the range_based_loops_gpu branch March 10, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants