Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace loop variable type in fpfh.hpp by correct type #2907

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Replace loop variable type in fpfh.hpp by correct type #2907

merged 1 commit into from
Mar 12, 2019

Conversation

SunBlack
Copy link
Contributor

There are a lot of warnings (comparison between signed and unsigned integer expressions [-Wsign-compare]) because of wrong loop variable type (Eigen::Index is a std::ptrdiff_t, which is a int (x86) or __int64 (x64)).

@SergioRAgostinho SergioRAgostinho merged commit bf6cf89 into PointCloudLibrary:master Mar 12, 2019
@SunBlack SunBlack deleted the fpfh_loop_variable_type branch March 12, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @taketwo @SergioRAgostinho