Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows FLANN issues #2910

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Fix Windows FLANN issues #2910

merged 1 commit into from
Mar 13, 2019

Conversation

SunBlack
Copy link
Contributor

IMPORTED_IMPLIB is only used for shared libraries and not for static. This is why you currently get an FLANN::FLANN-NOTFOUND.obj error with MSVC.

Additonally removed some includes, which caused this tools to look for flann/flann.hpp, which they don't need.

@UnaNancyOwen
Copy link
Member

LGTM 👍

@UnaNancyOwen UnaNancyOwen self-requested a review March 13, 2019 00:43
@UnaNancyOwen UnaNancyOwen merged commit 756655e into PointCloudLibrary:master Mar 13, 2019
@SunBlack SunBlack deleted the fix_flann_compile_issues branch March 13, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnaNancyOwen UnaNancyOwen UnaNancyOwen approved these changes

Assignees
No one assigned
Labels
module: cmake platform: windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @UnaNancyOwen @SergioRAgostinho