Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer std::log2 over custom implementation #2950

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Prefer std::log2 over custom implementation #2950

merged 1 commit into from
Mar 28, 2019

Conversation

SunBlack
Copy link
Contributor

No description provided.

@taketwo
Copy link
Member

taketwo commented Mar 27, 2019

There might be octree derivations in the wild that use these Log2 methods (they are not private). Therefore I think it's safer to deprecate them but keep around. Costs us nothing.

@taketwo taketwo added the c++14 label Mar 27, 2019
@taketwo taketwo merged commit d009887 into PointCloudLibrary:master Mar 28, 2019
@SunBlack SunBlack deleted the log2 branch March 28, 2019 12:03
@taketwo taketwo changed the title Use std::log2 instead of custom implementation Prefer std::log2 over custom implementation Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @taketwo @SergioRAgostinho