Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const qualifier to multiple methods in SAC module #2970

Conversation

PPokorski
Copy link
Contributor

This resolves #2959.

Verified

This commit was signed with the committer’s verified signature.
pentschev Peter Andreas Entschev
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PPokorski
Copy link
Contributor Author

Thank you as well!
By the way, the there seems to be something odd with the Build.Windows:

"D:\a\build\ALL_BUILD.vcxproj" (default target) (1) ->
"D:\a\build\surface\pcl_surface.vcxproj" (default target) (19) ->
(Link target) -> 
  d:\a\1\s\surface\src\surfel_smoothing.cpp : fatal error C1083: Cannot open compiler intermediate file: 'pcl_surface.dir\Release\surfel_smoothing.obj': Not enough space [D:\a\build\surface\pcl_surface.vcxproj]
  LINK : fatal error LNK1257: code generation failed [D:\a\build\surface\pcl_surface.vcxproj]

    397 Warning(s)
    2 Error(s)

@taketwo
Copy link
Member

taketwo commented Apr 5, 2019

Yeah, the agent ran out of space; this happens occasionally in Windows builds. We have a PR (#2935) that will hopefully solve this by releasing space used for vcpkg Boost installation.

@SergioRAgostinho SergioRAgostinho merged commit b4c785b into PointCloudLibrary:master Apr 5, 2019
@taketwo taketwo changed the title Added const qualifier to sample_consesus methods Add const qualifier to multiple methods in SAC module Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getters in SampleConsensus should have const qualifiers
3 participants