Prefer combined assignment operators #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunBlack
force-pushed
the
operator_usage_improvement
branch
from
f8ae91e to
f1050cc
Compare
SergioRAgostinho
approved these changes
Apr 22, 2019
taketwo
reviewed
Apr 23, 2019
added 6 commits
April 23, 2019 11:45
SunBlack
force-pushed
the
operator_usage_improvement
branch
from
f1050cc to
bcdbe8d
Compare
taketwo
approved these changes
Apr 23, 2019
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer usage of
+=-=*=/=%=^=&=|=.Changes are done via regex:
^( +)(\S+)\s*=\s*\2\s*\|(\s*[\d\w])=>\1\2 |=\3.There are a few hint left for
+=in module tracking, becauseParticleXYRand similar doesn't has defined required operator and I didn't wanted to define them in this PR ;).