Add version info on Windows for DLLs/Exe #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
SergioRAgostinho
approved these changes
May 3, 2019
taketwo
reviewed
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I want to see in upcoming release:
File description is sometimes a bit incorrect, because
SUBSYS_DESCorSUBSUBSYS_DESCare used for multiple files, but this we can fix later. More important for me was the version number.PR bases on #3044 (to prevent need to rebase ;) ).
//Edit: Just as hint: We don't see properties of selected file in screenshot. Instead we see properties of a DLL. I just selected the Exe to show you that the ICO file needs an update too^^ (only one resolution included and no transparency)