Change debug/release targets postfix on Windows #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Release: "_release" => "" - Debug: "_debug" => "d" - RelWithDebInfo: "_release" => "rd" - MinSizeRel: "_release" => "s"
|
Sounds good to me. Probably a good idea to ping @UnaNancyOwen for his opinion. |
|
I agree with your opinion, In general, the postfixes are only added to libraries for debug.
|
I know, that's why it is now configurable via CMake GUI 😉 |
SergioRAgostinho
approved these changes
May 3, 2019
taketwo
approved these changes
May 3, 2019
taketwo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_release=>_debug=>d_release=>rd_release=>sReason: Currently we are deploying files of PCL in our installer as they are, so they have the postfix
_release, which looks really ugly. All other dependencies of us are using no postfix for release build. Didn't found how Qt is handling RelWithDebInfo and MinSizeRel (Usage ofPOSTFIXI just found there in 3rd-Party directory of Chromium), so I took it from OpenSceneGraph (one of the first hits if you search forCMAKE_DEBUG_POSTFIX)