Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io] Migrate mutex, locks and cvs to C++14 #3068

Merged
merged 2 commits into from
May 8, 2019

Conversation

SergioRAgostinho
Copy link
Member

Let's see if this one compiles. It is a particularly challenging one because I'm not able to compile all these grabbers. I fear I might have forgotten some includes here and there. 🤞

@SergioRAgostinho SergioRAgostinho added changelog: ABI break Meta-information for changelog generation c++14 module: io labels May 7, 2019
@@ -38,10 +38,10 @@
/* SynchronizedQueue Template, taken from
* http://stackoverflow.com/questions/10139251/shared-queue-c
*/
#pragma once
Copy link
Member Author

@SergioRAgostinho SergioRAgostinho May 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really sure why I made this change to the if guards. I can revert it later if desired.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably realized that the current one is not correct (H vs HPP), leave alone the fact that we were supposed to switch to #pragma once anyway.

@SergioRAgostinho
Copy link
Member Author

A comment to discuss later, just noticed this in the CI log

-- The following subsystems will be built:
--   common
--   octree
--   io
--   kdtree
--   geometry
--   search
--   visualization
--   surface
--   sample_consensus
--   filters
--   2d
--   features
--   simulation
--   tracking
--   ml
--   segmentation
--   registration
--   recognition
--   outofcore
--   keypoints
--   stereo
--   examples
--   global_tests
--   tests_2d
--   tests_common
--   tests_features
--   tests_filters
--   tests_geometry
--   tests_io
--   tests_kdtree
--   tests_keypoints
--   tests_octree
--   tests_outofcore
--   tests_recognition
--   tests_registration
--   tests_search
--   tests_surface
--   tests_segmentation
--   tests_sample_consensus
--   tests_visualization
--   tools
--   apps
       building: 
       |_ in_hand_scanner
       |_ 3d_rec_framework
       |_ cloud_composer
       |_ point_cloud_editor
       |_ modeler
--   people
-- The following subsystems will not be built:
--   tests_people: Requires people.

Probably unrelated to this PR.

@@ -38,10 +38,10 @@
/* SynchronizedQueue Template, taken from
* http://stackoverflow.com/questions/10139251/shared-queue-c
*/
#pragma once
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably realized that the current one is not correct (H vs HPP), leave alone the fact that we were supposed to switch to #pragma once anyway.

@taketwo
Copy link
Member

taketwo commented May 7, 2019

Tutorials pipeline already failed, seems like an include is missing.

Probably unrelated to this PR.

Looking at Azure test analytics this test wasn't executed a single time in 30 days, so it's been a while since it's off.

@taketwo taketwo merged commit 257d56f into PointCloudLibrary:master May 8, 2019
@SergioRAgostinho SergioRAgostinho deleted the cv-io-rebase branch May 8, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: ABI break Meta-information for changelog generation module: io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants