-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[io] Migrate mutex, locks and cvs to C++14 #3068
[io] Migrate mutex, locks and cvs to C++14 #3068
Conversation
@@ -38,10 +38,10 @@ | |||
/* SynchronizedQueue Template, taken from | |||
* http://stackoverflow.com/questions/10139251/shared-queue-c | |||
*/ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not really sure why I made this change to the if guards. I can revert it later if desired.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably realized that the current one is not correct (H
vs HPP
), leave alone the fact that we were supposed to switch to #pragma once
anyway.
A comment to discuss later, just noticed this in the CI log
Probably unrelated to this PR. |
@@ -38,10 +38,10 @@ | |||
/* SynchronizedQueue Template, taken from | |||
* http://stackoverflow.com/questions/10139251/shared-queue-c | |||
*/ | |||
#pragma once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably realized that the current one is not correct (H
vs HPP
), leave alone the fact that we were supposed to switch to #pragma once
anyway.
Tutorials pipeline already failed, seems like an include is missing.
Looking at Azure test analytics this test wasn't executed a single time in 30 days, so it's been a while since it's off. |
Let's see if this one compiles. It is a particularly challenging one because I'm not able to compile all these grabbers. I fear I might have forgotten some includes here and there. 🤞