Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualization] Migrate mutex, locks and cvs to C++14 #3078

Merged

Conversation

SergioRAgostinho
Copy link
Member

No description provided.

@SergioRAgostinho SergioRAgostinho added changelog: ABI break Meta-information for changelog generation c++14 module: visualization labels May 9, 2019
@SergioRAgostinho SergioRAgostinho force-pushed the cv-visualization-rebase branch from 092ed88 to 8147043 Compare May 14, 2019 12:34
apps/src/openni_mls_smoothing.cpp Show resolved Hide resolved
apps/src/openni_voxel_grid.cpp Show resolved Hide resolved
tools/hdl_viewer_simple.cpp Show resolved Hide resolved
tools/vlp_viewer.cpp Show resolved Hide resolved
@SergioRAgostinho
Copy link
Member Author

It's finally done. Had to set up a Ubuntu VM, to replicate the CI.

@SergioRAgostinho
Copy link
Member Author

@taketwo have a last check please. I changed more than simple includes in this last batch of changes to get things to compile.

Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thanks!

@taketwo taketwo merged commit 62dcba7 into PointCloudLibrary:master May 15, 2019
@SergioRAgostinho SergioRAgostinho deleted the cv-visualization-rebase branch May 15, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: ABI break Meta-information for changelog generation module: visualization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants