Fix find_package_handle_standard_args incorrect argument in GTest finder script
#3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix regression introduced in 32d6cef * find_package_handle_standard_args is meant to be invoked with the same package name as a preceding call to find_package. Without it, it won't be able to tell, if the package is required or optional.
| @@ -421,12 +421,6 @@ configure_file("${pcl_config_h_in}" "${pcl_config_h}") | |||
| PCL_ADD_INCLUDES(common "" "${pcl_config_h}") | |||
| include_directories("${CMAKE_CURRENT_BINARY_DIR}/include") | |||
|
|
|||
| ### ---[ Set up for tests | |||
| enable_testing() | |||
There was a problem hiding this comment.
I deleted this because it is alreadly being invoked in the right place
Line 20 in 72f41b6
|
Is this fixing #2722? |
|
Yep. That's exactly the issue. Thanks for making the connection! |
taketwo
approved these changes
May 30, 2019
taketwo
changed the title
find_package_handle_standard_args incorrect argumentfind_package_handle_standard_args incorrect argument for GTestSource
taketwo
changed the title
find_package_handle_standard_args incorrect argument for GTestSourcefind_package_handle_standard_args incorrect argument in GTest finder script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same package name as a preceding call to find_package. Without it,
it won't be able to tell, if the package is required or optional.
Fixes #2722