Add support for device URI in OpenNI2Grabber constructor
#3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It additionally introduces a breaking change: when it fails to recognize a pattern in the device_id string and if the string is not empty, it now throws a pcl::IOException instead of calling getAnyDevice.
|
Isn't the "bus@address" pattern in the constructor description the same thing as the URI? Also there's no test for the feature, but I've no idea how to write one anyway. Is this ok? |
SergioRAgostinho
approved these changes
Jul 16, 2019
SergioRAgostinho
added
changelog: behavior change
Testing this functionality relies on the existence of external hardware which is not available for our CI. We also have no mocking mechanisms in place for grabbers (or for anything else) so don't worry about it. |
taketwo
approved these changes
Jul 17, 2019
taketwo
changed the title
OpenNI2Grabber constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It additionally introduces a breaking change: when it fails to
recognize a pattern in the device_id string and if the string is not
empty, it now throws a pcl::IOException instead of calling getAnyDevice.
Closes #3227.