PCL All-in-one Installer: add process to add/remove VTK path

[UnaNancyOwen]

This pull request has two changes.

• Fix uninstall process to remove environment variable.
  The variable name contained an unnecessary underscore.
  The conditional expression is always false and always runing process to remove variable.
  (It has not been a problem so far, because the remove path process that are not included in environment variables as there is virtually no change.)

  - StrCmp $DO_NOT_ADD_TO_PATH_ "1" doNotRemoveFromPath 0
  + StrCmp $DO_NOT_ADD_TO_PATH "1" doNotRemoveFromPath 0

• Add install and uninstall process to add and remove VTK path to environment variables PATH.
  This installer change for a temporary solution (It can be avoided by changing to dynamic linked VTK) for issue PCLVisualizer tutorial issue on Windows #1601. It just add/remove the VTK path in addition to the PCL path.
  I have already tested this installer/uninstaller on my environment. It works correctly without problem which option choose. It means we are ready to generate and publish the PCL 1.10.0 All-In-One Installer (that include pre-built PCL with dynamic linked VTK as a temporary solution for this issue).

  C:\Program Files\PCL\bin
  C:\Program Files\PCL\3rdParty\VTK\bin
  

  Note: This change should be undone once the issue PCLVisualizer tutorial issue on Windows #1601 is resolved.

[taketwo]

Thanks Tsukasa. One thing I don't understand entirely. Who (and how) controls whether the VTK in the all-in-one installer is dynamically or statically linked?

[UnaNancyOwen]

Who (and how) controls whether the VTK in the all-in-one installer is dynamically or statically linked?

We and users don’t have to do anything about it.
For example, even if VTK that included in PCL All-in-one Installer is a static link library, there is nothing pain with adding the path of PCL/3rdParty/VTK/bin to the environment variable (although it is unnecessary). So we don't need to control it.

The VTK configuration that should be included in the PCL All-in-one Installer depends on whether #1601 is resolved at the time of release.
If it is not resolved yet, I will dynamic linking VTK as temporary solution. If it was resolved at release time, I will statically linking VTK in the same way as so far.

I will be controls it and make a PCL All-in-one Installer. (It will made by me in recent years. Probably, It is only me will create PCL All-in-one Installer.)

Even it would be either, users will be able to use the same CMakeLists.txt that you used previously to generate own project. It is handled properly by CMake.

[taketwo]

Thanks for the clarification.