Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor polynomial calculations and remove memory leak #3392

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Refactor polynomial calculations and remove memory leak #3392

merged 1 commit into from
Oct 1, 2019

Conversation

kunaltyagi
Copy link
Member

In case | A^{-1}b | < epsilon, there was a memory leak.

The code was also duplicated and hiding the actual work.

If required:

  • L465 could be moved to the for loop
  • Comment cleanup can be done (for std::cout)

taketwo
taketwo reviewed Oct 1, 2019
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having ++CRevPtr on line 462 would look more canonical. Besides from that LGTM.

@kunaltyagi kunaltyagi force-pushed the polynomial_refactor branch from 790df76 to e728d80 Compare October 1, 2019 10:18
@kunaltyagi kunaltyagi merged commit 67b2e7b into PointCloudLibrary:master Oct 1, 2019
@kunaltyagi kunaltyagi deleted the polynomial_refactor branch October 1, 2019 16:42
@taketwo taketwo changed the title Refactored polynomial calculations and removed memory leak Refactor polynomial calculations and remove memory leak Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @taketwo