Add a flag to disable window autoresizing in ImageViewer
#3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
approved these changes
Oct 7, 2019
taketwo
changed the title
ImageViewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a small update to disable window autoscaling
resizing automatically on each addRGB() call is a big pain when using a constrained window manager (like i3) and also when the image is simply bigger than the screen...
in such case, the frame rate slow down to 1fps due to a loop in vtk SetSize() function here :
https://github.com/Kitware/VTK/blob/v8.2.0/Rendering/OpenGL2/vtkXOpenGLRenderWindow.cxx#L1035-L1039