Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCL_COMMON: removing default destructors - part 2 #3454

Merged
merged 2 commits into from
Nov 8, 2019
Merged

PCL_COMMON: removing default destructors - part 2 #3454

merged 2 commits into from
Nov 8, 2019

Conversation

lightyear15
Copy link
Contributor

Empty default constructors: what a waste of typing!

Empty default constructors: what a waste of typing!
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've highlighted below some comments which should also be ok to remove.

common/include/pcl/common/time.h Outdated Show resolved Hide resolved
common/include/pcl/common/vector_average.h Outdated Show resolved Hide resolved
common/include/pcl/correspondence.h Outdated Show resolved Hide resolved
common/include/pcl/correspondence.h Outdated Show resolved Hide resolved
common/include/pcl/correspondence.h Outdated Show resolved Hide resolved
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to maintainers: squash before merge.

@taketwo taketwo merged commit f2c1674 into PointCloudLibrary:master Nov 8, 2019
@taketwo
Copy link
Member

taketwo commented Nov 15, 2019

This PR introduces the following warning:

../keypoints/src/narf_keypoint.cpp: In member function ‘void pcl::NarfKeypoint::clearData()’:
../keypoints/src/narf_keypoint.cpp:75:52: warning: deleting object of polymorphic class type ‘pcl::RangeImage’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
     delete range_image_scale_space_[scale_space_idx];                                                   

@lightyear15 lightyear15 deleted the common_removeDtr branch December 13, 2019 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants