-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PCL_COMMON: removing default destructors - part 2 #3454
PCL_COMMON: removing default destructors - part 2 #3454
Conversation
Empty default constructors: what a waste of typing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've highlighted below some comments which should also be ok to remove.
common/include/pcl/common/transformation_from_correspondences.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to maintainers: squash before merge.
This PR introduces the following warning: ../keypoints/src/narf_keypoint.cpp: In member function ‘void pcl::NarfKeypoint::clearData()’:
../keypoints/src/narf_keypoint.cpp:75:52: warning: deleting object of polymorphic class type ‘pcl::RangeImage’ which has non-virtual destructor might cause undefined behavior [-Wdelete-non-virtual-dtor]
delete range_image_scale_space_[scale_space_idx]; |
Empty default constructors: what a waste of typing!
@SergioRAgostinho : here it is