Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default min and max angle for SAC cone models #3466

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Set default min and max angle for SAC cone models #3466

merged 1 commit into from
Nov 14, 2019

Conversation

mvieth
Copy link
Member

@mvieth mvieth commented Nov 13, 2019

Without this, a call to setMinMaxOpeningAngle is necessary, or else no model will be found. With default values, a possible source of error is eliminated.

@SergioRAgostinho SergioRAgostinho added changelog: behavior change Meta-information for changelog generation module: sample_consensus labels Nov 14, 2019
SergioRAgostinho
SergioRAgostinho approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@SergioRAgostinho SergioRAgostinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taketwo taketwo merged commit 5fa8bac into PointCloudLibrary:master Nov 14, 2019
@taketwo taketwo changed the title Set default min and max angle for sac cone models Set default min and max angle for SAC cone models Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
changelog: behavior change Meta-information for changelog generation module: sample_consensus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvieth @SergioRAgostinho @taketwo