Transition to standard smart pointers, part 10 #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taketwo
reviewed
Nov 18, 2019
taketwo
approved these changes
Nov 20, 2019
SergioRAgostinho
force-pushed
the
smart-10
branch
from
82b0ad2 to
6f30c8f
Compare
taketwo
added a commit
to taketwo/pcl
that referenced
this pull request
Jan 16, 2020
Even though pcl::detail::getMapping() is not officially a public API, it is used outside of PCL (in pcl_ros). Changing the smart pointer type from boost to std broke that code. This commit partially reverses the changes from PointCloudLibrary#3474, unbreaking pcl_ros. It also properly deprecates the function so that other (unknown to us) clients have time to update their code.
taketwo
added a commit
to taketwo/pcl
that referenced
this pull request
Jan 17, 2020
Even though pcl::detail::getMapping() is not officially a public API, it is used outside of PCL (in pcl_ros). Changing the smart pointer type from boost to std broke that code. This commit partially reverses the changes from PointCloudLibrary#3474, unbreaking pcl_ros. It also properly deprecates the function so that other (unknown to us) clients have time to update their code.
kunaltyagi
pushed a commit
that referenced
this pull request
Jan 17, 2020
Even though pcl::detail::getMapping() is not officially a public API, it is used outside of PCL (in pcl_ros). Changing the smart pointer type from boost to std broke that code. This commit partially reverses the changes from #3474, unbreaking pcl_ros. It also properly deprecates the function so that other (unknown to us) clients have time to update their code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #2792.