Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define RangeImage destructor as virtual #3477

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Define RangeImage destructor as virtual #3477

merged 1 commit into from
Nov 20, 2019

Conversation

SergioRAgostinho
Copy link
Member

@SergioRAgostinho SergioRAgostinho commented Nov 20, 2019 •
edited
Loading

Follows the decision in
#3472 (comment)

So maybe we pretend that RangeImage is not derived from PointCloud -> nothing is derived from PointCloud -> PointCloud is not supposed to be a base class -> PointCloud does not need a virtual destructor. And RangeImage gets a virtual destructor since we pretend it's at the root of a class hierarchy?

Closes #3472, closes #3470

@SergioRAgostinho SergioRAgostinho added this to the pcl-1.10.0 milestone Nov 20, 2019
@taketwo taketwo mentioned this pull request Nov 20, 2019
Closed
22 tasks
@taketwo taketwo merged commit 49ca041 into PointCloudLibrary:master Nov 20, 2019
@SergioRAgostinho SergioRAgostinho deleted the rangeimage-dtor branch November 22, 2019 12:21
@taketwo taketwo changed the title Define RangeImage dtor as virtual. Define RangeImage destructor as virtual Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: common
Projects
None yet
Milestone
pcl-1.10.0
Development

Successfully merging this pull request may close these issues.

Add virtual dtor to RangeImage
2 participants
@SergioRAgostinho @taketwo