Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to standard smart pointers, part 13 #3489

Merged

Conversation

SergioRAgostinho
Copy link
Member

@SergioRAgostinho SergioRAgostinho commented Nov 26, 2019

Partially addresses #2792.

All modules are compiling in my local environment. There were a couple of replacements which I was not able to perform. I battled a little with the compiler but eventually gave up.

- Encapsulate further boost::shared_ptr uses
- Normalize shared pointer interface
- Encapsulate further boost::shared_ptr uses
- Normalize shared pointer interface
@SergioRAgostinho SergioRAgostinho added this to the pcl-1.10.0 milestone Nov 26, 2019
@SergioRAgostinho
Copy link
Member Author

I had troubles performing the following replacement

extractLabeledEuclideanClusters (const boost::shared_ptr<pcl::PointCloud<PointT> > &host_cloud_,
const pcl::gpu::Octree::Ptr &tree,
float tolerance,
std::vector<PointIndices> &clusters,
unsigned int min_pts_per_cluster,
unsigned int max_pts_per_cluster);

It is causing an unintentional SFINAE and I can't figure out exactly how to overcome it. Give it a try if you can.

@taketwo
Copy link
Member

taketwo commented Dec 2, 2019

I think the only solution here is to specify the point type explicitly at the calling site, i.e. extractLabeledEuclideanClusters<pcl::PointXYZ>(pc, ...).

@SergioRAgostinho
Copy link
Member Author

Thank you for the tip. The compiler messages pointed me completely in the wrong direction.

@SergioRAgostinho SergioRAgostinho merged commit 39adbb7 into PointCloudLibrary:master Dec 3, 2019
@SergioRAgostinho SergioRAgostinho deleted the smart-13 branch December 3, 2019 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants