-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to standard smart pointers, part 13 #3489
Transition to standard smart pointers, part 13 #3489
Conversation
- Encapsulate further boost::shared_ptr uses - Normalize shared pointer interface
…oost::shared_ptr uses.
- Encapsulate further boost::shared_ptr uses - Normalize shared pointer interface
I had troubles performing the following replacement pcl/gpu/segmentation/include/pcl/gpu/segmentation/gpu_extract_labeled_clusters.h Lines 53 to 58 in 3e04ea7
It is causing an unintentional SFINAE and I can't figure out exactly how to overcome it. Give it a try if you can. |
I think the only solution here is to specify the point type explicitly at the calling site, i.e. |
Thank you for the tip. The compiler messages pointed me completely in the wrong direction. |
- Encapsulate further boost::shared_ptr uses - Normalize shared pointer interface
9ca6071
to
7c1de1b
Compare
Partially addresses #2792.
All modules are compiling in my local environment. There were a couple of replacements which I was not able to perform. I battled a little with the compiler but eventually gave up.