Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent memset for empty vector in 3rdparty/poisson4 #3537

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Prevent memset for empty vector in 3rdparty/poisson4 #3537

merged 1 commit into from
Jan 10, 2020

Conversation

kunaltyagi
Copy link
Member

Closes #3536

taketwo
taketwo approved these changes Jan 10, 2020
View reviewed changes
Copy link
Member

@taketwo taketwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taketwo taketwo merged commit a553c32 into PointCloudLibrary:master Jan 10, 2020
@kunaltyagi kunaltyagi deleted the third-party-vector branch January 10, 2020 18:49
@taketwo taketwo changed the title Prevent memset for empty vector Prevent memset for empty vector in 3rdparty/poisson Jan 18, 2020
@taketwo taketwo changed the title Prevent memset for empty vector in 3rdparty/poisson Prevent memset for empty vector in 3rdparty/poisson4 Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taketwo taketwo taketwo approved these changes

Assignees
No one assigned
Labels
module: surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined Behaviour - Null pointer passed as argument to memset.
2 participants
@kunaltyagi @taketwo