-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation of CUDA/GPU modules #3576
Conversation
Hmm, I still get:
and a bunch of others in And more surprisingly:
|
Sorry, did not notice the other PR (can we join them into one?) Still, after applying that patch I still get numerous errors in |
I'll apply those changes here. I can't compile gpu kinfu. CMake doesn't recognize my openni. The docker images will really help in this regard |
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this solves the shared_ptr
-related compiler errors for me.
The math_functions.hpp
-related issues are still present. Apparently that's an Eigen issue that has been fixed. Not sure in which release though (definitely not in 3.3.4 that comes with 18.04). According to the referenced commit message, the issue appeared in CUDA 9.1. So what we may want to do is use [Ubuntu 16.04 + CUDA 9.0] image on CI to make sure we don't hit this error. But that's offtopic for this PR anyway.
Lack of CI. My apologies