Remove deprecated checks for USE_ROS macro
#3690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
added
needs: code review
|
I think it is safe to remove this check altogether. The split up with ROS was finalized in 2013 IIRC, enough time for everyone to adapt. |
kunaltyagi
added
needs: more work
kunaltyagi
added
needs: code review
|
Is this PR to be held until 1.10.1 is out? Or are we already adopting the branched backport and cherry picking strategy? |
SergioRAgostinho
approved these changes
Mar 6, 2020
SergioRAgostinho
added
needs: pr merge
@taketwo gave his thumbs up since he doesn't know when he'd be ready for the 1.10.1 release. Officially, we haven't adopted it yet (no branch for backporting) |
|
We'll create it on the fly once we start working on it. |
taketwo
changed the title
USE_ROS macro
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USE_ROS was checked in multiple places, now it's checked in one place.
Easier to remove after deprecation period.