Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake grouping of tools targets #3709

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Fix CMake grouping of tools targets #3709

merged 3 commits into from
Mar 12, 2020

Conversation

larshg
Copy link
Contributor

@larshg larshg commented Mar 4, 2020 •
edited
Loading

Remove HAVE_VTK, guard simulation and gpu/people tools with BUILD_tools, add subsystem name for tools in io, outofcore, simulation and gpu/people.

@larshg larshg mentioned this pull request Mar 4, 2020
Closed
@larshg larshg changed the title Remove unused variables and guard simulation tools with BUILD_tools Remove HAVE_VTK, guard simulation tools with BUILD_tools, add subsystem name for tools in io, outofcore and simulation Mar 4, 2020
@larshg
Copy link
Contributor Author

larshg commented Mar 4, 2020 •
edited
Loading

Cuda and gpu modules are not added by default (its not set). But there is searched for CUDA by default.

Should I set Default to true to add CUDA/GPU subsystems?

@SergioRAgostinho
Copy link
Member

Should I set Default to true to add CUDA/GPU subsystems?

No, they are unstable modules :/

@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation needs: pr merge Specify why not closed/merged yet labels Mar 4, 2020
@kunaltyagi
Copy link
Member

@larshg Could you edit the title so it can appear in the changelog nicely?

@larshg larshg changed the title Remove HAVE_VTK, guard simulation tools with BUILD_tools, add subsystem name for tools in io, outofcore and simulation [Cmake]Remove unused variables and fix cmake for tools Mar 12, 2020
@larshg
Copy link
Contributor Author

larshg commented Mar 12, 2020

@kunaltyagi like this?

@larshg
Copy link
Contributor Author

larshg commented Mar 12, 2020 •
edited
Loading

I went ahead and updated this.

@larshg larshg requested a review from taketwo March 12, 2020 12:48
@SergioRAgostinho SergioRAgostinho merged commit c7840a8 into PointCloudLibrary:master Mar 12, 2020
@SergioRAgostinho SergioRAgostinho removed the needs: pr merge Specify why not closed/merged yet label Mar 12, 2020
@larshg larshg deleted the ChangeCmake branch March 12, 2020 14:16
@taketwo taketwo changed the title [Cmake]Remove unused variables and fix cmake for tools Fix CMake grouping of tools targets Mar 18, 2020
@taketwo taketwo added changelog: fix Meta-information for changelog generation and removed changelog: enhancement Meta-information for changelog generation labels Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo Awaiting requested review from taketwo

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: cmake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@larshg @SergioRAgostinho @kunaltyagi @taketwo