Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better PointType ctor and reduced warnings in register_point_struct.h #3732

Merged
merged 3 commits into from
Mar 12, 2020
Merged

Better PointType ctor and reduced warnings in register_point_struct.h #3732

merged 3 commits into from
Mar 12, 2020

Conversation

kunaltyagi
Copy link
Member

Also removed unneeded line continuation in macros

Warnings fixed:

  • unused variable
  • multi-line comment
  • sign mismatch

@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet module: common changelog: fix Meta-information for changelog generation labels Mar 12, 2020
@kunaltyagi kunaltyagi added this to the pcl-1.10.1 milestone Mar 12, 2020
@SergioRAgostinho SergioRAgostinho added needs: pr merge Specify why not closed/merged yet and removed needs: code review Specify why not closed/merged yet labels Mar 12, 2020
@kunaltyagi kunaltyagi mentioned this pull request Mar 12, 2020
Closed
@kunaltyagi kunaltyagi merged commit c70498a into PointCloudLibrary:master Mar 12, 2020
@kunaltyagi kunaltyagi deleted the warning-fix branch March 12, 2020 10:48
@kunaltyagi kunaltyagi removed the needs: pr merge Specify why not closed/merged yet label Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: common
Projects
None yet
Milestone
pcl-1.10.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @SergioRAgostinho