-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Ubuntu CI using matrix strategy #3783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Note: Needs Azure maintainer to
- update the docker image
- change the filename for the Ubuntu pipeline
before PR
PS: You need to change the docker image to the official one (it wouldn't fail since it doesn't run, how fun)
Have done it for now. If more changes are needed and have to be tested will do it on another branch with private images. |
Clang is disabled for the time being, so we don't need to update the Docker image. Could you update the PR to switch back to the official images? Then we merge and I update Azure? |
Have already switched back to official images in 2fd357b. Should i remove clang from the Dockerfile too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine having clang
in the Docker image, will make future experiments easier without the need to switch to private Dockerhub.
6560e59
to
dbc2997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please resolve the conflict and squash everything into one or two commits, as you prefer.
To prevent overloading the CI, temporarily disable until better solution is available
dbc2997
to
7a9a154
Compare
Done |
Merged and updated Azure settings. Could you please send a follow-up PR updating the corresponding badge in the README.md? |
As per discussions in #3595
Currently using private docker images, will update it to PCL images before PR as PCL images lack clang currently.
Ubuntu CI: Link