-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define PointIndices
based on the global Indices
type alias
#3822
Define PointIndices
based on the global Indices
type alias
#3822
Conversation
|
common/include/pcl/PointIndices.h
Outdated
|
||
namespace pcl | ||
{ | ||
struct PointIndices | ||
{ | ||
using Indices = std::vector<index_t>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if semantically it makes more sense to call this simply Type
. The enclosing type is already named *Indices
.
Just saw this now. 👍 |
1.11 target? |
Before we can proceed with deprecation, we'll need to update all interfaces that use |
PointIndices
for the global Indices
type aliasPointIndices
depends on the global Indices
type alias
PointIndices
depends on the global Indices
type aliasPointIndices
based on the global Indices
type alias
This PR changes nothing on the surface but it enables someone to locally change the
PCL_INDEX_SIGNED
tofalse
and find the places whereIndices
typedef isn't being used (There should be lots of such instances, but this can only find those that are "tested").Rest can be done via
grep