Mark non-const and non-modifying member functions as const #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dability-make-member-function-const' -fix
kunaltyagi
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
LGTM.
IMO, if a tool complains, we might as well apply the fix so we can uniformly check the tool for overall status of PCL.
I tried using XML for reporting clang-tidy results, and that's going to be a difficult goal; but maybe to avoid regressions, it might be better to integrate simple text output of errors ASAP, specially of the checks that you've been adding
kunaltyagi
changed the title
kunaltyagi
added
changelog: enhancement
kunaltyagi
changed the title
taketwo
approved these changes
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are done by:
run-clang-tidy -header-filter='.' -checks='-,readability-make-member-function-const' -fix//edit: I touched a few 3rd-Party code. As you have started to touch sometimes 3rd-Part code: It is okay or should I revert this?