-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Shift to clang-format-10
to resolve bug in clang-format-{7-9}
#3895
Conversation
This PR requires a sync between this and all other open PR which are dealing with:
|
Any reason why we are shifting to v10 as opposed to v11? |
Latest version available by default in Ubuntu 20.04 LTS. The diff is similar and migration to 11 later (when 20.04 or 20.10 or smthg adds it) will be easy. |
I'm going to push a new image to DockerHub and then trigger re-run here. |
@divmadan v11 is not published yet, so it would be not the best idea to switch to an unstable version ;-) Another question: Why |
Fair point. Sorry for hastily merging this without enough time for a proper discussion. But I needed to have this in master to unblock other PRs since the |
Just to add a point, |
Should we have a PR for Cpp14 as the standard? Or is sticking to "Latest" for formatting purpose ok? |
Probably? Our code is C++14 code, not C++20, so why confusing the formatter? |
clang-format-10
to resolve bug in clang-format-{7-9}
clang-format-8
has a bug which causes some incorrect formatting. Shifting to v10 would resolve that.Also modified is the cpp standard in the
.clang-format
. Should that beCpp14
instead ofLatest
?