-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pcl::utils::ignore
function to remove Doxygen warnings for unused arguments
#3942
Conversation
PCL_UNUSED
macro in favour of ignore
function
OOM on windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I expect a follow up PR touching all the (void)
coming next?
If it's not too much bother, please create an issue anyways.
PCL_UNUSED
macro in favour of ignore
functionignore
function to remove Doxygen warnings for unused arguments
Sorry, I'm late for the party (just a bit 😆). Did you consider backporting |
ignore
function to remove Doxygen warnings for unused argumentspcl::utils::ignore
function to remove Doxygen warnings for unused arguments
I could really only find references saying not to use it because it's not its intended use (e.g. SO). Moreover from its syntax I wouldn't really bet on it working that well with Doxygen. Can you point me to a "do use it" source? Also it seems to be some |
I don't have any such source; only the logic that it's better to use standard solutions when possible. But actually, I was not aware that |
I create a global lambda |
…PointCloudLibrary#3942) * remove PCL_UNUSED(x) in favour of ignore() * remove PCL_UNUSED from codebase
As I was discussing in #3932 (comment) adding
PCL_UNUSED
as it was was causing-Wunused-value
s in GCC, Clang and XCode. This solves the issue at least for the first two, so if XCode is ok with it I'm too.