Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PointCloud to conform to requirements of ReversibleContainer #3980

Merged
merged 3 commits into from
May 21, 2020
Merged

Update PointCloud to conform to requirements of ReversibleContainer #3980

merged 3 commits into from
May 21, 2020

Conversation

shrijitsingh99
Copy link
Contributor

@shrijitsingh99 shrijitsingh99 commented Apr 26, 2020 •
edited by kunaltyagi
Loading

Resolves #3966
Closes #2814

kunaltyagi
kunaltyagi requested changes Apr 26, 2020
View reviewed changes
common/include/pcl/point_cloud.h Outdated Show resolved Hide resolved
common/include/pcl/point_cloud.h Outdated Show resolved Hide resolved
common/include/pcl/point_cloud.h Outdated Show resolved Hide resolved
kunaltyagi
kunaltyagi previously approved these changes Apr 26, 2020
View reviewed changes
@kunaltyagi kunaltyagi dismissed their stale review April 26, 2020 15:32

CI fails

kunaltyagi
kunaltyagi approved these changes Apr 26, 2020
View reviewed changes
Copy link
Member

@kunaltyagi kunaltyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI

@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation module: common needs: more work Specify why not closed/merged yet labels May 20, 2020
@kunaltyagi
Copy link
Member

Please check the CI

@kunaltyagi kunaltyagi added this to the pcl-1.11.1 milestone May 20, 2020
@kunaltyagi kunaltyagi changed the title Update iterator to conform to requirements of ReversibleContainer Update PointCloud to conform to requirements of ReversibleContainer May 20, 2020
@shrijitsingh99
Copy link
Contributor Author

Retriggering CI since the logs got deleted.

@shrijitsingh99
Copy link
Contributor Author

CI seems to be green now.
The macOS might have been failing due to the SDK error in the Mac CI which was present for a brief period.

@kunaltyagi kunaltyagi added needs: code review Specify why not closed/merged yet and removed needs: more work Specify why not closed/merged yet labels May 21, 2020
@SergioRAgostinho SergioRAgostinho merged commit 746d05f into PointCloudLibrary:master May 21, 2020
@shrijitsingh99 shrijitsingh99 deleted the cloud-iterators branch June 11, 2020 11:21
koide3 pushed a commit to koide3/pcl that referenced this pull request Jul 6, 2020
@shrijitsingh99 @koide3
Update PointCloud to conform to requirements of `ReversibleContaine…
a5151db 
…r` (PointCloudLibrary#3980)

* Update iterator to conform to requirements of ReversibleContainer

* Fix const overloading return type mismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: common needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
pcl-1.11.1
3 participants
@shrijitsingh99 @kunaltyagi @SergioRAgostinho