Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded version number from tutorial CI #4058

Merged
merged 2 commits into from
May 9, 2020
Merged

Remove hardcoded version number from tutorial CI #4058

merged 2 commits into from
May 9, 2020

Conversation

kunaltyagi
Copy link
Member

Eliminates 1 TODO every release

@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation needs: code review Specify why not closed/merged yet module: ci labels May 6, 2020
@kunaltyagi
Copy link
Member Author

Technically, I only need to search in pcl_config.h, but I didn't want to hard-code the location

@kunaltyagi kunaltyagi added this to the pcl-1.11.0 milestone May 6, 2020
@kunaltyagi kunaltyagi mentioned this pull request May 6, 2020
Open
9 tasks
@kunaltyagi kunaltyagi marked this pull request as ready for review May 7, 2020 08:50
@kunaltyagi kunaltyagi merged commit 2ddd361 into PointCloudLibrary:master May 9, 2020
@kunaltyagi kunaltyagi deleted the tutorial-version-free branch May 9, 2020 07:01
@taketwo taketwo changed the title Removing hardcoded version number from tutorial CI Remove hardcoded version number from tutorial CI May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@taketwo taketwo Awaiting requested review from taketwo

Assignees
No one assigned
Labels
changelog: enhancement Meta-information for changelog generation module: ci needs: code review Specify why not closed/merged yet
Projects
None yet
Milestone
pcl-1.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kunaltyagi @SergioRAgostinho