Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visualization] Deprecate legacy OpenGL backend of VTK #4065

Merged
merged 1 commit into from
May 8, 2020
Merged

[visualization] Deprecate legacy OpenGL backend of VTK #4065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,9 @@ if(WITH_VTK AND NOT ANDROID)
endif()
if(${VTK_RENDERING_BACKEND} STREQUAL "OpenGL")
set(VTK_RENDERING_BACKEND_OPENGL_VERSION "1")
message(DEPRECATION "The rendering backend OpenGL is deprecated and not available anymore since VTK 8.2."
"Please switch to the OpenGL2 backend instead, which is available since VTK 6.2."
"Support of the deprecated backend will be dropped with PCL 1.13.")
elseif(${VTK_RENDERING_BACKEND} STREQUAL "OpenGL2")
set(VTK_RENDERING_BACKEND_OPENGL_VERSION "2")
endif()
Expand Down
2 changes: 2 additions & 0 deletions outofcore/tools/outofcore_viewer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
// PCL - visualziation
//#include <pcl/visualization/pcl_visualizer.h>
#include <pcl/visualization/common/common.h>
#if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2
#include <pcl/visualization/vtk/vtkVertexBufferObjectMapper.h>
#endif

//#include "vtkVBOPolyDataMapper.h"

Expand Down
1 change: 1 addition & 0 deletions visualization/include/pcl/visualization/vtk/vtkVertexBufferObject.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ class vtkUnsignedCharArray;
class vtkOpenGLExtensionManager;
class vtkRenderWindow;

PCL_DEPRECATED(1, 13, "The OpenGL backend of VTK is deprecated. Please switch to the OpenGL2 backend.")
class PCL_EXPORTS vtkVertexBufferObject : public vtkObject
{
public:
Expand Down
2 changes: 2 additions & 0 deletions visualization/include/pcl/visualization/vtk/vtkVertexBufferObjectMapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#pragma once

#include <pcl/pcl_exports.h>
#include <pcl/pcl_macros.h>

#include "vtkMapper.h"
#include "vtkSmartPointer.h"
Expand All @@ -34,6 +35,7 @@ class vtkShader2;
class vtkShaderProgram2;
class vtkVertexBufferObject;

PCL_DEPRECATED(1, 13, "The OpenGL backend of VTK is deprecated. Please switch to the OpenGL2 backend.")
class PCL_EXPORTS vtkVertexBufferObjectMapper : public vtkMapper
{
public:
Expand Down