Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary includes in examples #4071

Merged
merged 1 commit into from
May 9, 2020
Merged

Remove unnecessary includes in examples #4071

merged 1 commit into from
May 9, 2020

Conversation

SunBlack
Copy link
Contributor

@SunBlack SunBlack commented May 8, 2020

Tested with:

  • MSVC 2017 + VTK legacy OpenGL backend
  • GCC 8 + VTK OpenGL2 backend

@kunaltyagi
Copy link
Member

Compiling vs unnecessary are 2 different things. Can you use IWYU only on the examples and verify that this is a minimal patch?

Eg: using point types and not including because it is included transitively

@SunBlack
Copy link
Contributor Author

SunBlack commented May 8, 2020

I used IncludeToolbox as my Linux-VM-PC was in use. As examples does not have any header, the result should be the same (no header => no forward declaration possible)

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation module: examples needs: code review Specify why not closed/merged yet labels May 8, 2020
@kunaltyagi kunaltyagi merged commit a7334fb into PointCloudLibrary:master May 9, 2020
@SergioRAgostinho SergioRAgostinho removed the needs: code review Specify why not closed/merged yet label May 9, 2020
@SunBlack SunBlack deleted the cleanup_examples_includes branch May 9, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioRAgostinho SergioRAgostinho SergioRAgostinho approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunBlack @kunaltyagi @SergioRAgostinho