Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLY face definition accepts uint fields as well #4492

Merged
merged 1 commit into from
Nov 14, 2020
Merged

PLY face definition accepts uint fields as well #4492

merged 1 commit into from
Nov 14, 2020

Conversation

DaniilSNikulin
Copy link
Contributor

fixes #4491

kunaltyagi
kunaltyagi approved these changes Nov 5, 2020
View reviewed changes
io/src/ply_io.cpp Show resolved Hide resolved
@kunaltyagi kunaltyagi added changelog: enhancement Meta-information for changelog generation module: io needs: code review Specify why not closed/merged yet labels Nov 5, 2020
@kunaltyagi kunaltyagi changed the title added callback for uint index type for ply_parser PLY face definition accepts uchar fields as well Nov 5, 2020
@kunaltyagi
Copy link
Member

Please edit the title as needed

Is this a fix or an enhancement? Marked as enhancement, but feels like a fix

@DaniilSNikulin DaniilSNikulin changed the title PLY face definition accepts uchar fields as well PLY face definition accepts uint fields as well Nov 6, 2020
@DaniilSNikulin
Copy link
Contributor Author

Is this a fix or an enhancement? Marked as enhancement, but feels like a fix

I suppose this PR more likely is fix. PLY file format allow using uint for indices. So lack of support this case looks like a bug.

@kunaltyagi kunaltyagi added changelog: fix Meta-information for changelog generation and removed changelog: enhancement Meta-information for changelog generation labels Nov 7, 2020
@kunaltyagi kunaltyagi removed the needs: code review Specify why not closed/merged yet label Nov 14, 2020
@kunaltyagi kunaltyagi merged commit 6c2b123 into PointCloudLibrary:master Nov 14, 2020
@DaniilSNikulin DaniilSNikulin deleted the issue_4491_allow_uint_as_index_type branch November 14, 2020 08:23
@DaniilSNikulin DaniilSNikulin restored the issue_4491_allow_uint_as_index_type branch November 14, 2020 08:23
@DaniilSNikulin DaniilSNikulin deleted the issue_4491_allow_uint_as_index_type branch November 14, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvieth mvieth mvieth left review comments

@larshg larshg larshg approved these changes

@kunaltyagi kunaltyagi kunaltyagi approved these changes

Assignees
No one assigned
Labels
changelog: fix Meta-information for changelog generation module: io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[io] not support uint as scalar type
4 participants
@DaniilSNikulin @kunaltyagi @larshg @mvieth