[tracking] Use SFINAE instead of relying on macro PCL_TRACKING_NORMAL_SUPPORTED
#4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunaltyagi
force-pushed
the
tracking.sfinae
branch
from
92e5ade to
876621d
Compare
kunaltyagi
added
changelog: ABI break
kunaltyagi
changed the title
PCL_TRACKING_NORMAL_SUPPORTED
kunaltyagi
force-pushed
the
tracking.sfinae
branch
from
876621d to
94a573c
Compare
|
Any ideas on how to fix a linker error on MacOS? No issues. Reproduced the error (in apps module) |
Might not resolve red CI
|
Yay!! All tests pass |
mvieth
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
if constexpr would have been another nice solution, but since we are still at C++14 👍
An option would be to call computeTransformedPointCloudWithoutNormal inside the HasNoNormal variant (in addition to the warning) and/or to only allow setting use_normal_ to true if the point actually has a normal inside setUseNormal, but that is not a must.
larshg
approved these changes
Mar 15, 2021
|
Nice suggestion! That can be a future addition. Creating an issue from it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates the need for macro
PCL_TRACKING_NORMAL_SUPPORTEDPossibly fixes #4630