force setting cmake predefind VTK dir #5223
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
reviewed
Oct 17, 2022
| @@ -239,7 +239,7 @@ macro(find_VTK) | |||
| set(VTK_DIR "${PCL_ROOT}/3rdParty/VTK/lib/vtk-@VTK_MAJOR_VERSION@.@VTK_MINOR_VERSION@" CACHE PATH "The directory containing VTKConfig.cmake") | |||
| endif() | |||
| elseif(NOT VTK_DIR AND NOT ANDROID) | |||
| set(VTK_DIR "@VTK_DIR@" CACHE PATH "The directory containing VTKConfig.cmake") | |||
| set(VTK_DIR "@VTK_DIR@" CACHE PATH "The directory containing VTKConfig.cmake" FORCE) | |||
There was a problem hiding this comment.
Sorry for late replay, but you sure its here you want the Force?
This is where VTK_DIR is not set to any value, I guess it should be able to update it?
The issue you link to, uses the All-In-One installer, which are line 237 and 239 - which probably make sense, since the All-in-one installer is build with that specific version.
There was a problem hiding this comment.
I believe so.
The intention to add it in this file is that it would end up generating the PCLConfig.cmake mentioned in #4926
With FORCE, it allows the user to override the cache even if a value was already defined for VTK_DIR, which it does because it was added by the installer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered error #4926 when trying to link PCL with another library when it was compiled using a self-provided VTK (same as in issue).
I found 2 workarounds.
First, being to NOT provide
VTK_DIRto cmake (or remove from cache if already there even if empty) and leaving PCL set it.The second is to FORCE setting the value, basically ignoring what was provided by the user.
Since the displayed error happens when
VTK_DIRis specified, it is safe to assume it is already too late for case 1.fixes #4926